Rename builder parameter to onSuccess in RequestCubitBuilder (#49)#50
Merged
piotruela merged 3 commits intoJul 7, 2025
Merged
Conversation
- Rename the 'builder' parameter to 'onSuccess' in RequestCubitBuilder class - Update constructor comment to reflect the change - Update field declaration comment - Update all usages in build method (RequestSuccessState and RequestRefreshState) - Update all example code to use the new parameter name - Update all test files to use the new parameter name - Update README documentation to reflect the change This change makes the parameter name more descriptive and aligns with the naming convention of other state handlers (onInitial, onLoading, onError). Resolves: leancodepl#49
- Bump leancode_cubit_utils version from 0.3.2 to 0.4.0 - Bump leancode_cubit_utils_cqrs version from 0.3.1 to 0.4.0 - Update leancode_cubit_utils_cqrs dependency to ^0.4.0 - Add changelog entries documenting the breaking change This follows semantic versioning best practices where breaking changes in pre-1.0 software bump the minor version (0.x.y -> 0.x+1.0).
zltnDC
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Fixes #49
This PR implements the proposal to rename the
builderparameter toonSuccessinRequestCubitBuilderto improve API consistency and clarity.✅ Changes Made
builderparameter toonSuccessinRequestCubitBuilderThis is a breaking change that requires users to update their code from:
To:
The new parameter name onSuccess better aligns with the existing naming convention (onInitial, onLoading, onError) and makes the API more intuitive and consistent.